Add new icons for Segmentation templates #2779
Open
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aishad
force-pushed
the
ad/segmentation-templates-new-icons
branch
from
720c04f to
5929f31
Compare
PrescilliaA
reviewed
Apr 17, 2025
.changeset/fair-poets-reply.md
Outdated
| '@shopify/ui-extensions': minor | ||
| --- | ||
|
|
||
| Passing new icon types to the segment templates |
There was a problem hiding this comment.
small nit:
Suggested change
| Passing new icon types to the segment templates | |
| Add new icon types for segment templates |
aishad
force-pushed
the
ad/segmentation-templates-new-icons
branch
from
5929f31 to
cb0f787
Compare
LTiger14
reviewed
Apr 22, 2025
| @@ -22,7 +22,10 @@ export type CustomerSegmentTemplateIcon = | |||
| | 'followUpEmailMajor' | |||
| | 'confettiMajor' | |||
| | 'walletMajor' | |||
There was a problem hiding this comment.
We have a map in web so this doesn't matter but xxxxMajor is the old Polaris naming convention we could change our names to be more aligned.
There was a problem hiding this comment.
Oh sure, so should I name them the correct names and remove the map here ?
LTiger14
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes:https://github.com/Shopify/core-issues/issues/87053
Add icons for new templates:
🎩
Checklist